Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ob-installplatconf: Add return statements after ob_error() calls | Patrick McDermott | 2019-03-13 | 1 | -4/+11 |
| | |||||
* | Eliminate -a and -o options of [ commands | Patrick McDermott | 2019-03-13 | 4 | -13/+19 |
| | | | | POSIX marks these as obsolescent. | ||||
* | Protect [ commands from strings beginning with "-" | Patrick McDermott | 2019-03-13 | 11 | -60/+59 |
| | |||||
* | ob_parse_package_metadata(): Eliminate caching | Patrick McDermott | 2019-03-13 | 12 | -66/+10 |
| | | | | Cf. commit da45b6d. | ||||
* | TODO: Simplify applied patch tracking plan | Patrick McDermott | 2019-03-13 | 1 | -7/+2 |
| | |||||
* | TODO: Eliminate metadata caching | Patrick McDermott | 2019-03-13 | 1 | -11/+1 |
| | | | | | It complicates the code and hides metadata changes (unless timestamp checking gets added), all for little performance benefit. | ||||
* | TODO: Sort into general cleanup and functional changes | Patrick McDermott | 2019-03-13 | 2 | -17/+24 |
| | | | | And update heading parsing in Makefile.am. | ||||
* | opkbuild, ob-*: Exit with error on ob_set_text_domain() failure | Patrick McDermott | 2019-03-13 | 11 | -12/+40 |
| | |||||
* | TODO: Drop executable error exiting | Patrick McDermott | 2019-03-13 | 1 | -1/+0 |
| | |||||
* | ob-*: Add more return statements | Patrick McDermott | 2019-03-13 | 6 | -2/+35 |
| | |||||
* | ob-*: Replace exit with return | Patrick McDermott | 2019-03-13 | 9 | -18/+18 |
| | |||||
* | opkbuild: Add more return statements | Patrick McDermott | 2019-03-13 | 1 | -23/+35 |
| | |||||
* | opkbuild: Add return statements after ob_error() calls | Patrick McDermott | 2019-03-13 | 1 | -13/+35 |
| | |||||
* | ob-*: Add return statements after ob_error() calls | Patrick McDermott | 2019-03-13 | 4 | -18/+67 |
| | |||||
* | ob_parse_changelog(), ob_parse_control(): Explicitly assign null strings | Patrick McDermott | 2019-03-13 | 2 | -2/+2 |
| | | | | | POSIX say, "If value is not specified, the variable shall be given a null value." Make this explicit, for consistency. | ||||
* | TODO: Add xz-related tasks | Patrick McDermott | 2019-03-13 | 1 | -0/+5 |
| | |||||
* | opkbuild, ob-*: set -e | Patrick McDermott | 2019-03-13 | 11 | -1/+20 |
| | |||||
* | ob_substvars(): s/while true/while :/ | Patrick McDermott | 2019-03-13 | 1 | -1/+1 |
| | |||||
* | ob_parse_dep(): Fix crash on dep without version, arches, or plats | Patrick McDermott | 2019-03-13 | 1 | -4/+4 |
| | |||||
* | tests/*.sh: set -e | Patrick McDermott | 2019-03-13 | 7 | -0/+14 |
| | |||||
* | Don't let libopkbuild errors cause exit with -e | Patrick McDermott | 2019-03-13 | 7 | -41/+38 |
| | |||||
* | ob_substvars(), ob_init_package(): Call _ob_error_msg() | Patrick McDermott | 2019-03-13 | 3 | -3/+2 |
| | |||||
* | ob_error(): Make non-fatal | Patrick McDermott | 2019-03-13 | 2 | -5/+4 |
| | |||||
* | libopkbuild: Abort on invalid function arguments | Patrick McDermott | 2019-03-13 | 10 | -356/+159 |
| | | | | | | | | | | Shift arguments and abort instead of returning 125. Incorrect numbers of function arguments suggest application/library incompatibilities or serious errors by the application developer. Either way, the application developer should be made immediately aware of this (and not allowed to simply not check return values), and continuing to run and handle any further API calls may be unsafe. | ||||
* | _ob_abort(): New internal function to crash hard | Patrick McDermott | 2019-03-13 | 1 | -0/+7 |
| | |||||
* | TODO: echo is gone and IFS assignments are OK | Patrick McDermott | 2019-03-13 | 1 | -3/+0 |
| | |||||
* | tests/ob_parse_dep.sh: Replace echo and improve quotes in eval cmd | Patrick McDermott | 2019-03-13 | 1 | -2/+2 |
| | |||||
* | ob-unpacksource: Replace echo with here-document | Patrick McDermott | 2019-03-13 | 1 | -1/+5 |
| | | | | And drop the unnecessary grep. | ||||
* | ob-unpacksource: Make sed BRE POSIX-conformant | Patrick McDermott | 2019-03-13 | 1 | -1/+1 |
| | |||||
* | ob-unpacksource: Improve upstream archive counting | Patrick McDermott | 2019-03-13 | 1 | -6/+6 |
| | |||||
* | ob-gencontrol: Replace echo with here-document | Patrick McDermott | 2019-03-13 | 1 | -1/+4 |
| | |||||
* | ob-buildopk: Replace echo with printf | Patrick McDermott | 2019-03-13 | 1 | -1/+1 |
| | |||||
* | ob_match_arch(): Use clearer variable names | Patrick McDermott | 2019-03-13 | 1 | -9/+9 |
| | |||||
* | ob_match_arch(): Replace generated ERE with native SCL | Patrick McDermott | 2019-03-13 | 1 | -8/+20 |
| | |||||
* | _ob_validate_*(): Replace echo with here-document in grep commands | Patrick McDermott | 2019-03-12 | 1 | -6/+11 |
| | |||||
* | _ob_get_upstreamver(), _ob_get_distrev(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | _ob_get_doc_package_2(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_reduce_deps(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | lib/package.sh: Update copyright years | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_get_binary_packages(): Drop echo along with unnecessary assignment | Patrick McDermott | 2019-03-12 | 1 | -4/+2 |
| | |||||
* | ob_get_binary_packages(), _ob_set_binary_parameter(): Replace echo and grep ↵ | Patrick McDermott | 2019-03-12 | 1 | -9/+10 |
| | | | | with case | ||||
* | ob_get_binary_packages(): Fix indentation | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | lib/control.sh, lib/package.sh: Replace echo with here-document in tr commands | Patrick McDermott | 2019-03-12 | 2 | -15/+41 |
| | |||||
* | ob_parse_control(): Rewrite missing fields handling | Patrick McDermott | 2019-03-12 | 1 | -6/+7 |
| | | | | Get rid of echo and sed. | ||||
* | ob_parse_control(): Rewrite field checking | Patrick McDermott | 2019-03-12 | 1 | -23/+26 |
| | | | | | | | Get rid of the echo and sed pipeline and use case constructs instead of "[" commands with "${parameter%word}" expansions. The new logic also will only report duplicate unknown fields once. | ||||
* | *ob_[gs]et_*_parameter(): Make validation more immediately clear | Patrick McDermott | 2019-03-12 | 1 | -20/+12 |
| | |||||
* | TODO: eval commands have been evaluated | Patrick McDermott | 2019-03-12 | 1 | -1/+0 |
| | |||||
* | _ob_set_*_parameter(): Don't expand escaped value early in eval | Patrick McDermott | 2019-03-12 | 1 | -8/+2 |
| | |||||
* | ob_get_*_parameter(): Drop echo and improve quotes in eval cmds | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | ob_parse_version(): Improve eval safety | Patrick McDermott | 2019-03-12 | 1 | -4/+4 |
| | | | | | | | There likely wasn't a vulnerability here since versions are validated first, but unnecessary expansions like this in eval commands are bad practice, and a bug in the validation could have led to a vulnerability here. |