Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ob_parse_control(): Rewrite field checking | Patrick McDermott | 2019-03-12 | 1 | -23/+26 |
| | | | | | | | Get rid of the echo and sed pipeline and use case constructs instead of "[" commands with "${parameter%word}" expansions. The new logic also will only report duplicate unknown fields once. | ||||
* | *ob_[gs]et_*_parameter(): Make validation more immediately clear | Patrick McDermott | 2019-03-12 | 1 | -20/+12 |
| | |||||
* | _ob_set_*_parameter(): Don't expand escaped value early in eval | Patrick McDermott | 2019-03-12 | 1 | -8/+2 |
| | |||||
* | ob_get_*_parameter(): Drop echo and improve quotes in eval cmds | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | ob_parse_version(): Improve eval safety | Patrick McDermott | 2019-03-12 | 1 | -4/+4 |
| | | | | | | | There likely wasn't a vulnerability here since versions are validated first, but unnecessary expansions like this in eval commands are bad practice, and a bug in the validation could have led to a vulnerability here. | ||||
* | ob_parse_dep(): Drop echo and improve quotes in eval cmds | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | ob_substvars(): Replace echo in eval command | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_set_substvar(): Don't allow "_" in variable names | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | | | | | The character was allowed due to the details of the implementation, but the SPF 2.0 specification doesn't allow it. | ||||
* | ob_substvars(): Validate variable names | Patrick McDermott | 2019-03-12 | 1 | -0/+11 |
| | |||||
* | ob_set_substvar(): Make validation more immediately clear | Patrick McDermott | 2019-03-12 | 1 | -4/+2 |
| | | | | | | The original version in 000a27ff used a "${parameter:-word}" default value expansion to detect an empty string. Instead, let the case construct match empty strings directly. | ||||
* | ob_set_text_domain(): Update @return doc | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | lib/output.sh: Update copyright years | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | | | | Approximately none of the 2012 code remains. | ||||
* | ob_error(), ob_warn(), ob_info(): Internationalize | Patrick McDermott | 2019-03-12 | 1 | -3/+3 |
| | |||||
* | ob_error(), ob_warn(), ob_info(): Rewrite | Patrick McDermott | 2019-03-12 | 1 | -17/+12 |
| | |||||
* | ob_set_substvar(): Replace sed with read | Patrick McDermott | 2019-03-12 | 1 | -10/+3 |
| | |||||
* | _ob_parse_control_error(): Use _ob_warn_msg() | Patrick McDermott | 2019-03-12 | 1 | -12/+3 |
| | |||||
* | _ob_parse_changelog_error(): Use _ob_warn_msg() | Patrick McDermott | 2019-03-12 | 1 | -11/+2 |
| | |||||
* | ob_get_text_domain(): Replace echo with printf | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | ob_get_msg(): Replace echo with printf in eval | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | _ob_get_changelog_expect_str(): Drop unnecessary echo | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | _ob_get_changelog_expect_str(): Use _ob_get_msg() | Patrick McDermott | 2019-03-11 | 1 | -10/+1 |
| | |||||
* | _OB_TEXT_DOMAIN: Rename global var to _ob_text_domain | Patrick McDermott | 2019-03-11 | 1 | -8/+8 |
| | |||||
* | _ob_get_msg(): New internal function | Patrick McDermott | 2019-03-11 | 2 | -15/+17 |
| | | | | Use it in _ob_*_msg(). | ||||
* | Use (or plan to use) _ob_warn_msg() | Patrick McDermott | 2019-03-11 | 3 | -15/+12 |
| | |||||
* | _ob_*_msg(): New internal functions | Patrick McDermott | 2019-03-11 | 1 | -1/+43 |
| | |||||
* | ob_set_text_domain(): Don't print warning message on error | Patrick McDermott | 2019-03-11 | 1 | -6/+0 |
| | |||||
* | ob_set_text_domain(): Exit early if messages already loaded | Patrick McDermott | 2019-03-11 | 1 | -1/+8 |
| | |||||
* | Makefile.am, lib/local.mk: Extract TODO comments from libopkbuild sources | Patrick McDermott | 2019-03-11 | 1 | -0/+3 |
| | |||||
* | ob_parse_changelog(): Pass args, not global vars, to cb | Patrick McDermott | 2019-03-11 | 1 | -42/+29 |
| | | | | And update test file. | ||||
* | ob_parse_changelog(): Replace if construct with case | Patrick McDermott | 2019-03-11 | 1 | -88/+95 |
| | |||||
* | Revert "lib/error.sh: New file" | Patrick McDermott | 2019-03-11 | 2 | -53/+0 |
| | | | | This reverts commit 31a6f6452e6de2bcf27b5a141613b183ee29ce63. | ||||
* | Revert "ob_parse_control(): Run parse error callback" | Patrick McDermott | 2019-03-11 | 1 | -6/+35 |
| | | | | This reverts commit d80290a2f8c9f069261da78afd2f275e84923d0f. | ||||
* | ob_parse_control(): Run parse error callback | Patrick McDermott | 2019-01-05 | 1 | -35/+6 |
| | |||||
* | lib/error.sh: New file | Patrick McDermott | 2019-01-05 | 2 | -0/+53 |
| | |||||
* | Revert "[WIP] ob_parse_control(): Run an error callback" | Patrick McDermott | 2019-01-05 | 1 | -19/+41 |
| | | | | This reverts commit d1f79411c618a7a3d078430450631dfca85c2a07. | ||||
* | [WIP] ob_parse_control(): Run an error callback | Patrick McDermott | 2019-01-05 | 1 | -41/+19 |
| | |||||
* | _OB_LF: Define and use newline constant | Patrick McDermott | 2019-01-05 | 3 | -8/+7 |
| | |||||
* | ob_parse_control(): Replace [ commands after callbacks | Patrick McDermott | 2019-01-05 | 1 | -4/+2 |
| | |||||
* | ob_parse_control(): Update/improve field_cb documentation | Patrick McDermott | 2019-01-05 | 1 | -8/+11 |
| | |||||
* | ob_parse_control(): Add a user_data operand | Patrick McDermott | 2019-01-05 | 2 | -15/+21 |
| | |||||
* | ob_parse_control(): Pass field name and value as args | Patrick McDermott | 2019-01-05 | 2 | -21/+23 |
| | |||||
* | ob_parse_control(): Replace param prefix/suffix removals with read | Patrick McDermott | 2019-01-05 | 1 | -5/+4 |
| | |||||
* | ob_parse_control(): Replace if construct with case | Patrick McDermott | 2019-01-05 | 1 | -54/+55 |
| | |||||
* | ob_parse_version(): Document | Patrick McDermott | 2018-12-29 | 1 | -0/+19 |
| | |||||
* | ob_get_system_path(): Document | Patrick McDermott | 2018-12-29 | 1 | -0/+15 |
| | |||||
* | ob_get_system_arch(), ob_get_system_plat(): Document | Patrick McDermott | 2018-12-29 | 1 | -0/+16 |
| | |||||
* | ob_get_system_*(): Return 1 and hide message on error | Patrick McDermott | 2018-12-29 | 1 | -2/+2 |
| | |||||
* | ob_validate_source_name(), ob_validate_binary_name(): Document | Patrick McDermott | 2018-12-29 | 1 | -1/+17 |
| | |||||
* | lib/changelog.sh, lib/control.sh, lib/locale.sh: Update copyright years | Patrick McDermott | 2018-12-29 | 3 | -3/+3 |
| | |||||
* | ob_substvars(): Add a TODO comment | Patrick McDermott | 2018-12-29 | 1 | -0/+1 |
| |