From fe18aaff0f0f3964fcabfe21566d43344921383d Mon Sep 17 00:00:00 2001 From: P. J. McDermott Date: Sat, 21 Jan 2012 13:08:34 -0500 Subject: Note a bug in handling of optional fields. --- diff --git a/src/oh-gencontrol b/src/oh-gencontrol index 1c322d5..e0af798 100644 --- a/src/oh-gencontrol +++ b/src/oh-gencontrol @@ -112,6 +112,12 @@ else >> ${control} [ ${?} -eq 1 ] && missing_field Architecture + # XXX: If an optional field is omitted, its name is still written out. + # Fields should be handled by wrapper functions, e.g.: + # copy_required_field Maintainer + # copy_required_field ${binpkg} Description + # copy_optional_field Homepage + # Optional fields. { printf 'Essential: ' && oh_get_field ${binpkg} Essential;} >> ${control} { printf 'Depends: ' && oh_get_field ${binpkg} Depends;} >> ${control} -- cgit v0.9.1