summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorP. J. McDermott <pjm@nac.net>2012-01-21 13:08:34 (EST)
committer P. J. McDermott <pjm@nac.net>2012-01-21 13:11:36 (EST)
commitfe18aaff0f0f3964fcabfe21566d43344921383d (patch)
tree38128edb44d0b0ceebc54de534a0dcfbc3bbfb83 /src
parentecd96656b993eba29d93e46c29caf7ad4ba67713 (diff)
Note a bug in handling of optional fields.
Diffstat (limited to 'src')
-rw-r--r--src/oh-gencontrol6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/oh-gencontrol b/src/oh-gencontrol
index 1c322d5..e0af798 100644
--- a/src/oh-gencontrol
+++ b/src/oh-gencontrol
@@ -112,6 +112,12 @@ else
>> ${control}
[ ${?} -eq 1 ] && missing_field Architecture
+ # XXX: If an optional field is omitted, its name is still written out.
+ # Fields should be handled by wrapper functions, e.g.:
+ # copy_required_field Maintainer
+ # copy_required_field ${binpkg} Description
+ # copy_optional_field Homepage
+
# Optional fields.
{ printf 'Essential: ' && oh_get_field ${binpkg} Essential;} >> ${control}
{ printf 'Depends: ' && oh_get_field ${binpkg} Depends;} >> ${control}