From 03fa1b027e4d92df4be3b5d1cca5bae38ba19707 Mon Sep 17 00:00:00 2001 From: P. J. McDermott Date: Thu, 13 Mar 2014 23:40:07 -0400 Subject: Fix grep commands in init scripts. The exit status of a pipeline is the exit status of the last command in the pipeline. If the last command is ":", the exit status will always be 0, regardless of whether grep finds the specified pattern. So just use grep's -q command. According to the documentation for GNU grep, some older grep implementations lacked this option. But we're only running these scripts on BusyBox grep, which unconditionally includes this option. --- (limited to 'src.etc/init.d/mdev') diff --git a/src.etc/init.d/mdev b/src.etc/init.d/mdev index 9a896f4..8052c3b 100755 --- a/src.etc/init.d/mdev +++ b/src.etc/init.d/mdev @@ -4,7 +4,7 @@ start() { printf 'Enabling device hotplugging... ' - if ! mount | grep -F ' /dev ' 2>&1 | :; then + if ! mount | grep -Fq ' /dev '; then mount -t tmpfs -o noexec,nosuid,mode=0755 tmpfs /dev fi @@ -20,7 +20,7 @@ stop() printf '\n' >/proc/sys/kernel/hotplug - if mount | grep -F ' /dev ' 2>&1 | :; then + if mount | grep -Fq ' /dev '; then umount /dev fi -- cgit v0.9.1