diff options
| author | Patrick McDermott <patrick.mcdermott@libiquity.com> | 2020-06-30 02:02:41 (EDT) |
|---|---|---|
| committer | Patrick McDermott <patrick.mcdermott@libiquity.com> | 2020-06-30 02:43:38 (EDT) |
| commit | b6626e0e23ee817383e29fc1f2428bca169a20db (patch) | |
| tree | 2436d6eec82fea14bbf5cfdebace88ad4760a5bf | |
| parent | 5742acad2cbdc7811dfd5f97d41f901efe714a1d (diff) | |
ob-buildopk: Don't chown data
This partially reverts commit 483800ef9ecf5ce98c0f6894e222bf08a68bb617.
| -rw-r--r-- | NEWS | 7 | ||||
| -rw-r--r-- | TODO | 3 | ||||
| -rw-r--r-- | src/ob-buildopk.sh | 2 |
3 files changed, 8 insertions, 4 deletions
@@ -24,6 +24,13 @@ Utilities: directories. - ob-gencontrol qualifies names in "Package" fields. - ob-buildopk and ob-genchanges qualify names in "*.opk" file names. + * ob-buildopk no longer sets the owner and group of all data files to + 0:0, as done since version 4.1.0. This is not expected to change + file owners or groups in any ProteanOS packages at this time, + because: + - oh-fixperms (used in most packages) also sets owners and groups + - "build" makefile "install" targets are run with (fake) superuser + privileges. libopkbuild: @@ -20,9 +20,6 @@ Functional Changes * Someday restore (removed in commit 3cc4e19) and implement `ob_summarize_package_arch()` and `ob_summarize_package_plat()` to queue source packages for build daemons. - * ob-buildopk does this: - find "${binary}.control" "${binary}.data" | xargs chown -h 0:0 - Should it?? Copyright ========= diff --git a/src/ob-buildopk.sh b/src/ob-buildopk.sh index 3370807..d22accc 100644 --- a/src/ob-buildopk.sh +++ b/src/ob-buildopk.sh @@ -77,7 +77,7 @@ build_opk() # This utility runs with (fake) privileges, so we can chown what we're # about to tar. - find "${binary}.control" "${binary}.data" | xargs chown -h 0:0 + find "${binary}.control" | xargs chown -h 0:0 (cd -- "${binary}.control" && find '.' | LC_ALL=C sort ${sort_r} | \ ${TAR} -cf '../control.tar' --no-recursion -T -) |