summaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* ob_parse_changelog(), ob_parse_control(): Explicitly assign null stringsPatrick McDermott2019-03-132-2/+2
| | | | | POSIX say, "If value is not specified, the variable shall be given a null value." Make this explicit, for consistency.
* ob_substvars(): s/while true/while :/Patrick McDermott2019-03-131-1/+1
|
* ob_parse_dep(): Fix crash on dep without version, arches, or platsPatrick McDermott2019-03-131-4/+4
|
* Don't let libopkbuild errors cause exit with -ePatrick McDermott2019-03-134-26/+27
|
* ob_substvars(), ob_init_package(): Call _ob_error_msg()Patrick McDermott2019-03-132-2/+2
|
* ob_error(): Make non-fatalPatrick McDermott2019-03-131-3/+2
|
* libopkbuild: Abort on invalid function argumentsPatrick McDermott2019-03-139-353/+158
| | | | | | | | | | Shift arguments and abort instead of returning 125. Incorrect numbers of function arguments suggest application/library incompatibilities or serious errors by the application developer. Either way, the application developer should be made immediately aware of this (and not allowed to simply not check return values), and continuing to run and handle any further API calls may be unsafe.
* _ob_abort(): New internal function to crash hardPatrick McDermott2019-03-131-0/+7
|
* ob_match_arch(): Use clearer variable namesPatrick McDermott2019-03-131-9/+9
|
* ob_match_arch(): Replace generated ERE with native SCLPatrick McDermott2019-03-131-8/+20
|
* _ob_validate_*(): Replace echo with here-document in grep commandsPatrick McDermott2019-03-121-6/+11
|
* _ob_get_upstreamver(), _ob_get_distrev(): Replace echo with printfPatrick McDermott2019-03-121-2/+2
|
* _ob_get_doc_package_2(): Replace echo with printfPatrick McDermott2019-03-121-1/+1
|
* ob_reduce_deps(): Replace echo with printfPatrick McDermott2019-03-121-1/+1
|
* lib/package.sh: Update copyright yearsPatrick McDermott2019-03-121-1/+1
|
* ob_get_binary_packages(): Drop echo along with unnecessary assignmentPatrick McDermott2019-03-121-4/+2
|
* ob_get_binary_packages(), _ob_set_binary_parameter(): Replace echo and grep ↵Patrick McDermott2019-03-121-9/+10
| | | | with case
* ob_get_binary_packages(): Fix indentationPatrick McDermott2019-03-121-2/+2
|
* lib/control.sh, lib/package.sh: Replace echo with here-document in tr commandsPatrick McDermott2019-03-122-15/+41
|
* ob_parse_control(): Rewrite missing fields handlingPatrick McDermott2019-03-121-6/+7
| | | | Get rid of echo and sed.
* ob_parse_control(): Rewrite field checkingPatrick McDermott2019-03-121-23/+26
| | | | | | | Get rid of the echo and sed pipeline and use case constructs instead of "[" commands with "${parameter%word}" expansions. The new logic also will only report duplicate unknown fields once.
* *ob_[gs]et_*_parameter(): Make validation more immediately clearPatrick McDermott2019-03-121-20/+12
|
* _ob_set_*_parameter(): Don't expand escaped value early in evalPatrick McDermott2019-03-121-8/+2
|
* ob_get_*_parameter(): Drop echo and improve quotes in eval cmdsPatrick McDermott2019-03-121-2/+2
|
* ob_parse_version(): Improve eval safetyPatrick McDermott2019-03-121-4/+4
| | | | | | | There likely wasn't a vulnerability here since versions are validated first, but unnecessary expansions like this in eval commands are bad practice, and a bug in the validation could have led to a vulnerability here.
* ob_parse_dep(): Drop echo and improve quotes in eval cmdsPatrick McDermott2019-03-121-2/+2
|
* ob_substvars(): Replace echo in eval commandPatrick McDermott2019-03-121-1/+1
|
* ob_set_substvar(): Don't allow "_" in variable namesPatrick McDermott2019-03-121-2/+2
| | | | | The character was allowed due to the details of the implementation, but the SPF 2.0 specification doesn't allow it.
* ob_substvars(): Validate variable namesPatrick McDermott2019-03-121-0/+11
|
* ob_set_substvar(): Make validation more immediately clearPatrick McDermott2019-03-121-4/+2
| | | | | | The original version in 000a27ff used a "${parameter:-word}" default value expansion to detect an empty string. Instead, let the case construct match empty strings directly.
* ob_set_text_domain(): Update @return docPatrick McDermott2019-03-121-1/+1
|
* lib/output.sh: Update copyright yearsPatrick McDermott2019-03-121-1/+1
| | | | Approximately none of the 2012 code remains.
* ob_error(), ob_warn(), ob_info(): InternationalizePatrick McDermott2019-03-121-3/+3
|
* ob_error(), ob_warn(), ob_info(): RewritePatrick McDermott2019-03-121-17/+12
|
* ob_set_substvar(): Replace sed with readPatrick McDermott2019-03-121-10/+3
|
* _ob_parse_control_error(): Use _ob_warn_msg()Patrick McDermott2019-03-121-12/+3
|
* _ob_parse_changelog_error(): Use _ob_warn_msg()Patrick McDermott2019-03-121-11/+2
|
* ob_get_text_domain(): Replace echo with printfPatrick McDermott2019-03-111-1/+1
|
* ob_get_msg(): Replace echo with printf in evalPatrick McDermott2019-03-111-1/+1
|
* _ob_get_changelog_expect_str(): Drop unnecessary echoPatrick McDermott2019-03-111-1/+1
|
* _ob_get_changelog_expect_str(): Use _ob_get_msg()Patrick McDermott2019-03-111-10/+1
|
* _OB_TEXT_DOMAIN: Rename global var to _ob_text_domainPatrick McDermott2019-03-111-8/+8
|
* _ob_get_msg(): New internal functionPatrick McDermott2019-03-112-15/+17
| | | | Use it in _ob_*_msg().
* Use (or plan to use) _ob_warn_msg()Patrick McDermott2019-03-113-15/+12
|
* _ob_*_msg(): New internal functionsPatrick McDermott2019-03-111-1/+43
|
* ob_set_text_domain(): Don't print warning message on errorPatrick McDermott2019-03-111-6/+0
|
* ob_set_text_domain(): Exit early if messages already loadedPatrick McDermott2019-03-111-1/+8
|
* Makefile.am, lib/local.mk: Extract TODO comments from libopkbuild sourcesPatrick McDermott2019-03-111-0/+3
|
* ob_parse_changelog(): Pass args, not global vars, to cbPatrick McDermott2019-03-111-42/+29
| | | | And update test file.
* ob_parse_changelog(): Replace if construct with casePatrick McDermott2019-03-111-88/+95
|