Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
... | |||||
* | ob_parse_changelog(), ob_parse_control(): Explicitly assign null strings | Patrick McDermott | 2019-03-13 | 2 | -2/+2 |
| | | | | | POSIX say, "If value is not specified, the variable shall be given a null value." Make this explicit, for consistency. | ||||
* | ob_substvars(): s/while true/while :/ | Patrick McDermott | 2019-03-13 | 1 | -1/+1 |
| | |||||
* | ob_parse_dep(): Fix crash on dep without version, arches, or plats | Patrick McDermott | 2019-03-13 | 1 | -4/+4 |
| | |||||
* | Don't let libopkbuild errors cause exit with -e | Patrick McDermott | 2019-03-13 | 4 | -26/+27 |
| | |||||
* | ob_substvars(), ob_init_package(): Call _ob_error_msg() | Patrick McDermott | 2019-03-13 | 2 | -2/+2 |
| | |||||
* | ob_error(): Make non-fatal | Patrick McDermott | 2019-03-13 | 1 | -3/+2 |
| | |||||
* | libopkbuild: Abort on invalid function arguments | Patrick McDermott | 2019-03-13 | 9 | -353/+158 |
| | | | | | | | | | | Shift arguments and abort instead of returning 125. Incorrect numbers of function arguments suggest application/library incompatibilities or serious errors by the application developer. Either way, the application developer should be made immediately aware of this (and not allowed to simply not check return values), and continuing to run and handle any further API calls may be unsafe. | ||||
* | _ob_abort(): New internal function to crash hard | Patrick McDermott | 2019-03-13 | 1 | -0/+7 |
| | |||||
* | ob_match_arch(): Use clearer variable names | Patrick McDermott | 2019-03-13 | 1 | -9/+9 |
| | |||||
* | ob_match_arch(): Replace generated ERE with native SCL | Patrick McDermott | 2019-03-13 | 1 | -8/+20 |
| | |||||
* | _ob_validate_*(): Replace echo with here-document in grep commands | Patrick McDermott | 2019-03-12 | 1 | -6/+11 |
| | |||||
* | _ob_get_upstreamver(), _ob_get_distrev(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | _ob_get_doc_package_2(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_reduce_deps(): Replace echo with printf | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | lib/package.sh: Update copyright years | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_get_binary_packages(): Drop echo along with unnecessary assignment | Patrick McDermott | 2019-03-12 | 1 | -4/+2 |
| | |||||
* | ob_get_binary_packages(), _ob_set_binary_parameter(): Replace echo and grep ↵ | Patrick McDermott | 2019-03-12 | 1 | -9/+10 |
| | | | | with case | ||||
* | ob_get_binary_packages(): Fix indentation | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | lib/control.sh, lib/package.sh: Replace echo with here-document in tr commands | Patrick McDermott | 2019-03-12 | 2 | -15/+41 |
| | |||||
* | ob_parse_control(): Rewrite missing fields handling | Patrick McDermott | 2019-03-12 | 1 | -6/+7 |
| | | | | Get rid of echo and sed. | ||||
* | ob_parse_control(): Rewrite field checking | Patrick McDermott | 2019-03-12 | 1 | -23/+26 |
| | | | | | | | Get rid of the echo and sed pipeline and use case constructs instead of "[" commands with "${parameter%word}" expansions. The new logic also will only report duplicate unknown fields once. | ||||
* | *ob_[gs]et_*_parameter(): Make validation more immediately clear | Patrick McDermott | 2019-03-12 | 1 | -20/+12 |
| | |||||
* | _ob_set_*_parameter(): Don't expand escaped value early in eval | Patrick McDermott | 2019-03-12 | 1 | -8/+2 |
| | |||||
* | ob_get_*_parameter(): Drop echo and improve quotes in eval cmds | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | ob_parse_version(): Improve eval safety | Patrick McDermott | 2019-03-12 | 1 | -4/+4 |
| | | | | | | | There likely wasn't a vulnerability here since versions are validated first, but unnecessary expansions like this in eval commands are bad practice, and a bug in the validation could have led to a vulnerability here. | ||||
* | ob_parse_dep(): Drop echo and improve quotes in eval cmds | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | |||||
* | ob_substvars(): Replace echo in eval command | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | ob_set_substvar(): Don't allow "_" in variable names | Patrick McDermott | 2019-03-12 | 1 | -2/+2 |
| | | | | | The character was allowed due to the details of the implementation, but the SPF 2.0 specification doesn't allow it. | ||||
* | ob_substvars(): Validate variable names | Patrick McDermott | 2019-03-12 | 1 | -0/+11 |
| | |||||
* | ob_set_substvar(): Make validation more immediately clear | Patrick McDermott | 2019-03-12 | 1 | -4/+2 |
| | | | | | | The original version in 000a27ff used a "${parameter:-word}" default value expansion to detect an empty string. Instead, let the case construct match empty strings directly. | ||||
* | ob_set_text_domain(): Update @return doc | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | |||||
* | lib/output.sh: Update copyright years | Patrick McDermott | 2019-03-12 | 1 | -1/+1 |
| | | | | Approximately none of the 2012 code remains. | ||||
* | ob_error(), ob_warn(), ob_info(): Internationalize | Patrick McDermott | 2019-03-12 | 1 | -3/+3 |
| | |||||
* | ob_error(), ob_warn(), ob_info(): Rewrite | Patrick McDermott | 2019-03-12 | 1 | -17/+12 |
| | |||||
* | ob_set_substvar(): Replace sed with read | Patrick McDermott | 2019-03-12 | 1 | -10/+3 |
| | |||||
* | _ob_parse_control_error(): Use _ob_warn_msg() | Patrick McDermott | 2019-03-12 | 1 | -12/+3 |
| | |||||
* | _ob_parse_changelog_error(): Use _ob_warn_msg() | Patrick McDermott | 2019-03-12 | 1 | -11/+2 |
| | |||||
* | ob_get_text_domain(): Replace echo with printf | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | ob_get_msg(): Replace echo with printf in eval | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | _ob_get_changelog_expect_str(): Drop unnecessary echo | Patrick McDermott | 2019-03-11 | 1 | -1/+1 |
| | |||||
* | _ob_get_changelog_expect_str(): Use _ob_get_msg() | Patrick McDermott | 2019-03-11 | 1 | -10/+1 |
| | |||||
* | _OB_TEXT_DOMAIN: Rename global var to _ob_text_domain | Patrick McDermott | 2019-03-11 | 1 | -8/+8 |
| | |||||
* | _ob_get_msg(): New internal function | Patrick McDermott | 2019-03-11 | 2 | -15/+17 |
| | | | | Use it in _ob_*_msg(). | ||||
* | Use (or plan to use) _ob_warn_msg() | Patrick McDermott | 2019-03-11 | 3 | -15/+12 |
| | |||||
* | _ob_*_msg(): New internal functions | Patrick McDermott | 2019-03-11 | 1 | -1/+43 |
| | |||||
* | ob_set_text_domain(): Don't print warning message on error | Patrick McDermott | 2019-03-11 | 1 | -6/+0 |
| | |||||
* | ob_set_text_domain(): Exit early if messages already loaded | Patrick McDermott | 2019-03-11 | 1 | -1/+8 |
| | |||||
* | Makefile.am, lib/local.mk: Extract TODO comments from libopkbuild sources | Patrick McDermott | 2019-03-11 | 1 | -0/+3 |
| | |||||
* | ob_parse_changelog(): Pass args, not global vars, to cb | Patrick McDermott | 2019-03-11 | 1 | -42/+29 |
| | | | | And update test file. | ||||
* | ob_parse_changelog(): Replace if construct with case | Patrick McDermott | 2019-03-11 | 1 | -88/+95 |
| |